Don't update Salsa inputs unnecessarily#1313
Merged
Merged
Conversation
Contributor
|
I'm remembering that I read this in https://hackmd.io/5ddaZLKYSVC_YTTD3SzRDw?view#Input-Structs 
|
DavisVaughan
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1212
Flagged by Fable. There's no backdating for Salsa inputs! So we have to conditionally set them to prevent invalidation.
Unfortunately there's no easy way to gate the setters. We could wrap the Salsa inputs in a newtype but that would have ergonomy costs.
Since new code that writes to the database should be fairly rare from now on, we can just be careful about this when it comes up.